From: Ian Campbell Date: Tue, 7 Jul 2015 08:46:15 +0000 (+0100) Subject: xen: arm: drop redundant extra call to vgic_reserve_virq X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~2916 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https://%22%22/%22http:/www.example.com/cgi/%22https:/%22%22?a=commitdiff_plain;h=eed5e395e068fe1df46eee91d2ab0428fb8b5f42;p=xen.git xen: arm: drop redundant extra call to vgic_reserve_virq This is only needed if we are giving the IRQ to dom0 (as opposed to setting it up for passthrough due to xen,passthrough property). There is already a call to vgic_reserve_virq inside the if ( need_mapping ), so drop this one. Signed-off-by: Ian Campbell Reviewed-by: Julien Grall --- diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 04460b022b..980a2a32c3 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1024,12 +1024,6 @@ static int handle_device(struct domain *d, struct dt_device_node *dev) irq = res; DPRINT("irq %u = %u\n", i, irq); - /* - * Checking the return of vgic_reserve_virq is not - * necessary. It should not fail except when we try to map - * the IRQ twice. This can legitimately happen if the IRQ is shared - */ - vgic_reserve_virq(d, irq); res = irq_permit_access(d, irq); if ( res )